Skip to content

fix: inspectdb base problems #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

fix: inspectdb base problems #430

wants to merge 20 commits into from

Conversation

KrymmyEM
Copy link

Inspectdb problems #421

  • Adding enum data types
    • PostgreSQL
    • MySQL
  • Little fix problem with field naming
  • Fix problem with fields name mismatch
  • Fix problem with table name mismatch
  • Since tortoise-orm assumes "id" as a primary key, the problem of unique fields in postgresql is fixed.

KrymmyEM and others added 16 commits February 25, 2025 12:00
@KrymmyEM
[UP] inspectdb/__init__ class Inspect {+ def charenum_field}
40cde79
@KrymmyEM
[UP] inspectdb/__init__ class Inspect {~ def inspect +119 "class Meta…
b51b4ea 
… ..." }
@KrymmyEM
[UP] inspectdb/__init__.py +class EnumDataType
3a7cfbe
@KrymmyEM
[UP] inspectdb/postgres.py class InspectPostgres {+ def get_enums*}
e80e3ed
@KrymmyEM
[UP] inspectdb/postgres.py class InspectPostgres {~ def field_map}
cd39edc
@KrymmyEM
[UP] inspectdb/__init__ ~class EnumDataType {+ def get_class_name; en…
764913f 
…um_type}
@KrymmyEM
[UP/FIX] inspectdb/postgres.py ~class InspectPostgres {~get_enums_dat…
c1ea756 
…a_types;get_columns}
@KrymmyEM
[FIX] inspectdb/postgres.py +5| +EnumDataType
0bc2e0a
@KrymmyEM
[FIX] inspectdb/sqlite.py class InspectSQLite {~ field_map}
dd40655
@KrymmyEM
[FIX] inspectdb/sqlite.py class InspectSQLite {~ field_map}
97b6472
@KrymmyEM
[UP] inspectdb/mysql.py ~class InspectMySQL {+def *enum*; ~def field_…
5cbf42e 
…map}
@KrymmyEM
[UP] inspectdb/__init__ class Inspect {~ def inspect }
1ec012b
@KrymmyEM
Merge branch 'tortoise:dev' into fix/inspectdb
645f0e2
@KrymmyEM
[UP] inspectdb/__init__ class Inspect {~ def get_field_string }
dea80cc
@KrymmyEM
[UP] inspectdb/__init__ class EnumDataType {~ def get_class_name }
70268a3
@KrymmyEM
[UP] inspectdb/postgres.py -112|
52c90f4
waketzheng
waketzheng requested changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@waketzheng waketzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make style and make check to follow code style.

@KrymmyEM KrymmyEM requested a review from waketzheng March 2, 2025 15:37
@waketzheng
Copy link
Contributor

Would be great if you can add some unittests.

@KrymmyEM
Copy link
Author

How I can add some unittests for server type DBMS?

@waketzheng
Copy link
Contributor

How I can add some unittests for server type DBMS?

Something like this: https://github.com/tortoise/aerich/tree/dev/tests/test_inspectdb.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waketzheng waketzheng Awaiting requested review from waketzheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrymmyEM @waketzheng