[WIP] Fix pydantic optional #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

waketzheng wants to merge 3 commits into tortoise:develop from waketzheng:fix-pydantic-optional

Contributor

waketzheng commented Aug 1, 2025

Description

Fixes #1977

Motivation and Context

How Has This Been Tested?

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

waketzheng added 3 commits

July 26, 2025 22:27


          fix not none field with default accept None value for pydantic model

c15a2be


          Use default_factory if field.default is callable

9346f32


          fix: default value is async function

415d8bd

codspeed-hq bot commented Aug 1, 2025

CodSpeed Performance Report

Merging #1985 will not alter performance

_{Comparing waketzheng:fix-pydantic-optional (415d8bd) with develop (65bc23e)}

Summary

✅ 16 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet