Skip to content

Conversation

@waketzheng
Copy link
Contributor

Description

  1. Remove poetry section in pyproject.toml which cause poetry add git+https://github.com/tortoise/tortoise-orm to get wrong version '0.0.0' instead of '0.25.1'
  2. Only test poetry add when explicitly set env TORTOISE_TEST_POETRY_ADD to be true, because this test cost too much time and no need to run with every dialect

Motivation and Context

Fix wrong version and reduce ci execute time

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 30, 2025

CodSpeed Performance Report

Merging #2025 will not alter performance

Comparing waketzheng:remove-poetry-section (c0243eb) with develop (752762c)

Summary

✅ 16 untouched

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19801995488

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.717%

Totals Coverage Status
Change from base Build 19726043557: 0.0%
Covered Lines: 6631
Relevant Lines: 7195

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants