-
Notifications
You must be signed in to change notification settings - Fork 193
TUI visualization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…lding Signed-off-by: Sachin Bhat <[email protected]>
Signed-off-by: Sachin Bhat <[email protected]>
Reorder imports; drop unused sys/ticker Use MouseButton enum; normalize tuple unpacking/slider axes Make zip strictness explicit; fix whitespace/indentation Signed-off-by: Sachin Bhat <[email protected]>
Signed-off-by: Sachin Bhat <[email protected]>
add mmap-backed raw loader and duration helpers add waveform bucket/min-max helpers and math utilities expose Python bindings including numpy fast path Signed-off-by: Sachin Bhat <[email protected]>
add clap-based CLI and navigation state render min/max buckets with autoscaled Y-range add status/footer UI and keyboard shortcuts Signed-off-by: Sachin Bhat <[email protected]>
run visualizer via module entrypoint in Makefile use Rust autoscale/decimation when bindings exist track stubs and update ignore list Signed-off-by: Sachin Bhat <[email protected]>
Signed-off-by: Sachin Bhat <[email protected]>
Signed-off-by: Sachin Bhat <[email protected]>
manishin2050
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job
have you checked.?
|
Hi Sachin, thanks for putting this together. This is a big and interesting contribution. The TUI visualizer is a great idea and the structure you’ve set up around core utilities, the TUI crate, and the Python packaging is solid. I like the direction here, especially separating core logic and making the TUI able to reuse it. The docs and example commands are also helpful. Before this moves forward, I think it would be good to slow this PR down into a more focused series. Right now it mixes several large changes: workspace setup, Python packaging, core utilities, and the new TUI. That makes it harder to review and reason about. A few thoughts: • It would help to split this into smaller PRs (for example: core utilities, TUI visualizer, Python/package reorg). Overall, the idea is strong and the implementation looks promising. If you’re okay breaking this into smaller pieces, I think this could move much more smoothly. |
Hi @torvalds,
Great project! Just thought that I could contribute a TUI visualizer to the project. I also did some reorganisation of the project by introducing package management with uv built with maturin to play well with rust crates. Now
visualize.pyhas been moved inside thepython/audionoisedirectory with linter (basedpyright + ruff) fixes. Now this visualizer optionally uses functions exposed from the rust crate ABI. I believe what is missing is live audio capture but the TUI should be fairly flexible. Here is what needs to be done:cpal/rodiofor ALSA/Pulse/JACK/CoreAudio) to feed samples.--liveflag to differentiate it from the current file-based inputI will send this in as a draft PR for now. Let me know if you would like me to add live capture in this patch-series or in a new set of patches.
You can test it with:
Thanks,
Sachin