Small fixes for robustness #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle missing/empty directory in the SeymourDuncan Makefile target to avoid shell errors. - Add a isfinite() check in convert.c to prevent NaN/Inf from hitting the DSP loop if atof receives malformed input.
RinZ27
force-pushed
the
robustness-fixes
branch
from
bfb9899 to
c584417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small tweaks to make the toolkit a bit more robust:
SeymourDuncanMakefile target to avoid shell errors.isfinite()check inconvert.cto prevent NaN/Inf from hitting the DSP loop ifatofreceives malformed input.