audio: increase HTTP stream timeout after send for TTS #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit af99de4 ("audio: reduce HTTP Stream timeout to 2s") we changed the HTTP Stream timeout to 2s so we can indicate early when we're not able to connect to WIS. Unfortunately ESP HTTP Client only has a single timeout value, and we now also abort the HTTP connection to WIS if TTS takes longer than 2s. We want to keep the timeout reasonably low, as having to wait for a TTS response for too long isn't great for UX, but 2s is too short for long TTS responses. Leave the initial timeout at 2s, but increase it to 10s on the HTTP_STREAM_POST_REQUEST event, which happens after the HTTP client sent header and body to WIS, but before fetching the response.
stintel
force-pushed
the
fix/http_stream_timeout
branch
from
7879883 to
a57b41d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit af99de4 ("audio: reduce HTTP Stream timeout to 2s") we changed the HTTP Stream timeout to 2s so we can indicate early when we're not able to connect to WIS.
Unfortunately ESP HTTP Client only has a single timeout value, and we now also abort the HTTP connection to WIS if TTS takes longer than 2s. We want to keep the timeout reasonably low, as having to wait for a TTS response for too long isn't great for UX, but 2s is too short for long TTS responses.
Leave the initial timeout at 2s, but increase it to 10s on the HTTP_STREAM_POST_REQUEST event, which happens after the HTTP client sent header and body to WIS, but before fetching the response.