Replace SHGetFolderPathW with SHGetKnownFolderPath #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Sep 8, 2025
This allow mypy to ignore this file on any os other then windows
for more information, see https://pre-commit.ci
gaborbernat
reviewed
Sep 8, 2025
| @@ -12,6 +12,8 @@ | |||
| if TYPE_CHECKING: | |||
| from collections.abc import Callable | |||
|
|
|||
| assert sys.platform == "win32" | |||
There was a problem hiding this comment.
I don't think we should do this.
There was a problem hiding this comment.
It's just that mypy is kinda shit for file with platform specific code.
Anyways, it breaks the doc generation.
To be honest, i don't know how to fix those kinds of mypy error.
There was a problem hiding this comment.
Yeah you need to solve it differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #348