Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid false warnings about missing UV_CONSTRAINT variable #162

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

ssbarnea
Copy link
Member

  • Fixes issue where UV_CONSTRAINT warning was disabled even when
    defined
  • Avoids repeated messages on each environment_variables use

@ssbarnea ssbarnea requested a review from gaborbernat as a code owner January 27, 2025 11:29
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please!

@gaborbernat gaborbernat marked this pull request as draft January 27, 2025 17:07
- Fixes issue where UV_CONSTRAINT warning was disabled even when
  defined
- Avoids repeated messages on each environment_variables use
@ssbarnea ssbarnea force-pushed the fix/uv-constraints-warning branch from de2821a to 24d4264 Compare January 28, 2025 09:44
@ssbarnea ssbarnea marked this pull request as ready for review January 28, 2025 09:45
@ssbarnea
Copy link
Member Author

I knew it and still I was hopping that you might miss it.

@ssbarnea ssbarnea requested a review from gaborbernat January 28, 2025 09:46
@gaborbernat gaborbernat merged commit dac8b82 into tox-dev:main Jan 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants