Skip to content

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Sep 1, 2025

Fixes #187.
Fixes tox-dev/tox-gh#175.

self._install() is doing the same thing, but also calls the hook beforehand.

@Viicos Viicos requested a review from gaborbernat as a code owner September 1, 2025 21:32
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the task to validate against such regressions?

@Viicos
Copy link
Contributor Author

Viicos commented Sep 2, 2025

Any guidance on how to do so? Should I setup some kind of mock plugin that emulates tox-gh and make assertions on the hook calls (tox_on_install(), etc)?

@gaborbernat
Copy link
Member

Any guidance on how to do so? Should I setup some kind of mock plugin that emulates tox-gh and make assertions on the hook calls (tox_on_install(), etc)?

Yes, there are example of this in the test suite.

@Viicos
Copy link
Contributor Author

Viicos commented Sep 13, 2025

I've had a look but did not find any existing test setting up another custom plugin, and it's going to take me some time to fully understand the test logic of the codebase. I'll put this on hold.

@gaborbernat gaborbernat marked this pull request as draft October 8, 2025 14:10
@gaborbernat gaborbernat marked this pull request as ready for review October 9, 2025 19:53
@gaborbernat gaborbernat merged commit f9357e7 into tox-dev:main Oct 9, 2025
23 checks passed
@Viicos Viicos deleted the tox_on_install branch October 9, 2025 22:50
@Viicos
Copy link
Contributor Author

Viicos commented Oct 9, 2025

Thanks for merging @gaborbernat. Unfortunately, this did not fix the issue (example job: https://github.com/Viicos/clamdpy/actions/runs/18391352062/job/52402083554?pr=7). Feel free to reopen the related issues, I'm personally dropping tox from now and switching to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UvVenvLockRunner doesn't call MANAGER.tox_on_install tox-gh fails with uv-venv-lock-runner

2 participants