Draft
Conversation
…and react-native-vector-icons peer-dependencies
Collaborator
|
Great refactor. Do you need some help here? |
Owner
Author
|
@AugustoAleGon definitely. But that would be after the refactor. I'll be adding some more comments in here. The plan as stated earlier in #31 is to reduce the number of props significantly, make styling configurable and also fix the most pressing issues. During this refactor, some of the features would be removed until we figure out how best to re-add them back without having such a huge number of props. Below is the current type definition: export interface MultiSelectProps {
items: MultiSelectItem[];
selectedItems: string[];
onSelectedItemsChange: (selectedItems: string[]) => void;
onAddItem?: (newItems: MultiSelectItem[]) => void;
isSingleSelection?: boolean;
hideSubmitButton?: boolean
hideTags?: boolean;
}It will most likely change before I wrap up the refactor in a couple of days. I will make a list of all features removed during the refactor and we can split those up. |
Collaborator
|
@toystars awesome looking good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.