Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send region via include #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nbrantut
Copy link

@nbrantut nbrantut commented Jun 5, 2019

This is an attempt at solving #18. I am new to elisp so I hope it is not too badly written; but it works. I made the function julia-repl-send-region-through-tmp-file with two optional arguments with region start and end, so it can be used programmatically if needed.

Let me know what you think. (again the code might probably be simplified, I am not used to elisp).

@tpapp
Copy link
Owner

tpapp commented Aug 25, 2019

Thanks for the PR. My problem with this approach is that

  1. if the tmp file is not deleted (which seems to be the case), the directory is cluttered with these things,

  2. if the tmp file would be deleted, then the code location for the methods defined there becomes invalid, as the file no longer exists.

Instead, I would recommend just putting things in a module and using Revise.jl, or possibly using includet once #64 is finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants