Skip to content

Conversation

@Ja-sonYun
Copy link

@Ja-sonYun Ja-sonYun commented Oct 21, 2025

vim/vim@ef92555

patch version checked with git tag --contains ef92555 in vim repository.

netrw#BrowseX() was changed in Vim patch 9.1.1485 to take a single argument and handle remote detection internally. Use one-arg call when that patch is present, and fallback to the old two-arg form for older builds.

@tpope
Copy link
Owner

tpope commented Oct 22, 2025

Would it be feasible to check the version in g:netrwPlugin_loaded instead?

@Ja-sonYun
Copy link
Author

Ja-sonYun commented Oct 23, 2025

Do you mean g:loaded_netrwPlugin? If so, that’s what I initially considered too.
However, in patch 9.1.1486 the value of g:netrwPlugin_loaded is still v181, so users building Vim from that patch will get an incorrect function usage.
Additionally, patch 9.1.1484 also v181, so the variable does not accurately indicate the behavioral change introduced in 9.1.1485.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants