Skip to content

Minor fixes to the HTML table displaying the list of comments #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor fixes to the HTML table displaying the list of comments #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ae2bb
Fix a typo in the CSS class
SebDieBln Aug 30, 2023
9c7fc3c
Fix wrong HTML tags for values in columns author and timestamp
SebDieBln Aug 30, 2023
c0bf358
Change column label from 'Date' to 'Timestamp'
SebDieBln Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions code_comments/templates/comments.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h1>Code Comments</h1>
</form>
<table class="listing code-comments">
<thead>
<tr class="tarc-columns">
<tr class="trac-columns">
<th class="check"><input type="checkbox" /></th>
<py:for each="header in sortable_headers">
<th class="$header.html_class"><a href="$header.link">$header.name</a></th>
Expand All @@ -47,8 +47,8 @@ <h1>Code Comments</h1>
<tr class="${idx % 2 and 'odd' or 'even'}">
<td class="check"><input type="checkbox" id="checked-$comment.id" /></td>
<td>$comment.id</td>
<th>$comment.author</th>
<th>${comment.formatted_date()}</th>
<td>$comment.author</td>
<td>${comment.formatted_date()}</td>
<td>${comment.path_link_tag()}</td>
<td>$comment.html</td>
<td>${comment.get_ticket_links()}</td>
Expand Down
2 changes: 1 addition & 1 deletion code_comments/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def prepare_sortable_headers(self):
displayed_sorting_methods = \
('id', 'author', 'time', 'path', 'text')
displayed_sorting_method_names = \
('ID', 'Author', 'Date', 'Path', 'Text')
('ID', 'Author', 'Timestamp', 'Path', 'Text')
query_args = self.req.args
if 'page' in query_args:
del query_args['page']
Expand Down