Invert blocked status check in EelinkProtocolDecoder#5842
Invert blocked status check in EelinkProtocolDecoder#5842DemonExposer wants to merge 1 commit intotraccar:masterfrom
Conversation
|
Please attach the supporting documents. |
|
I'm not going to share a copyrighted document without having any authorization to do so. For the newer firmware versions, such as 2.1, it states for bit 6 == 0: "The relay control is not triggered" and for bit 6 == 1: "The relay control is triggered" I feel like the newer description is very ambiguous, but I don't see a reason for them to switch it around. Also, according to my tests, they didn't. However, in |
|
Sorry, but we won't be able to accept it without documentation. At the very least you have to share it privately for verification. |
Status bytes sometimes get interpreted incorrectly because of bit 6 (for blocked status) being processed incorrectly. In
decodeNew, it is not the same as indecodeStatus. I assume this was done because of the change in firmware documentation by Eelink.I know they describe it weird, which could lead you to believe that they flipped the functionality, but this is not the case. They kept it the same.
I tested this with some devices where some packets show
blocked = trueand some showblocked = false. The change that I made fixes this to always show the correct status.