Introduce Await component for nicer template usage
#716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `load` function/helper combo gets the job done, but this
new component has a similar top-level API but requires no `if`-based
branching. Instead, it uses named blocks to render the resulting state.
import { Async } from 'ember-async-data';
<template>
<Async @DaTa={{Promise.resolve 123}}>
<:pending>Still waiting...</:pending>
<:resolved as |value|>
The value is: {{value}}.
</:resolved>
<:rejected>Whoops! Something went wrong!</:rejected>
</Async>
</template>
This ends up being both briefer *and* less error prone, not least since
it provides the resolved value automatically from the `resolved` block,
whereas expressly checking `{{#if someAsyncData.isResolved}}` *allowed*
the further `{{someAsyncData.value}}` access but did not provide it
automatically.
…ompatible with the template-tag plugin, and prettier@v3 is not compatible with the current version of eslint/stylelint configs (we could do further upgrades tho, but this is what we want in the long run anyway)
|
@NullVoxPopuli do you think we could split infra updates into separate PR to keep this managed/focused? |
chriskrycho
reviewed
Oct 3, 2023
Yes, this makes sense -- usually my way of working is to spike all the way to the end / green (so that I know my direction is even valid), and then pull the isolated stuff out.
ah awesome! I'll rebase once that's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes?: #709
The existing
loadfunction/helper combo gets the job done, but this new component has a similar top-level API but requires noif-based branching. Instead, it uses named blocks to render the resulting state.This ends up being both briefer and less error prone, not least since it provides the resolved value automatically from the
resolvedblock, whereas expressly checking{{#if someAsyncData.isResolved}}allowed the further{{someAsyncData.value}}access but did not provide it automatically.