allow loading of external config file #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 for this functionality. Are you able to write a test for this as well? Also, please follow the eslint guidelines so that this passes the PR CI tests. |
Author
|
will do and on it! |
disciple-dev
suggested changes
Oct 12, 2016
disciple-dev
left a comment
disciple-dev
left a comment
There was a problem hiding this comment.
Need to remove semicolons on lines 39 & 42 for CI tests to pass.
Member
|
This functionality might be solved by trailsjs/trails#236 or trailsjs/trailpack#39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change allows users to load an external autoreload config. If non is provided the default one is used. Essentially, gives the user more control of this pack's underlining behavior without having to touch the npm-module directly.
How to use
module.exports = {
cwd: '/srv/project',
ignoreInitial: true,
usePolling: true
}