Skip to content

Self-signed SSL cert in Browserstack #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Self-signed SSL cert in Browserstack #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9afa210
Re-enable self-signed SSL cert
bencmbrook Feb 14, 2023
f49e06d
Merge branch 'main' into bencmbrook/browserstack-cert
bencmbrook Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions karma.browserstack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,13 @@ module.exports = (config) => {
os: 'OS X',
os_version: 'Monterey',
},
// TODO: https://github.com/transcend-io/penumbra/issues/249
// bs_firefox_pc: {
// base: 'BrowserStack',
// browser: 'Firefox',
// browser_version: '102.0',
// os: 'Windows',
// os_version: '10',
// },
bs_firefox_pc: {
base: 'BrowserStack',
browser: 'Firefox',
browser_version: '102.0',
os: 'Windows',
os_version: '10',
},
bs_edge_pc: {
base: 'BrowserStack',
browser: 'Edge',
Expand Down Expand Up @@ -57,10 +56,9 @@ module.exports = (config) => {
build: `penumbra@${packageJson.version} - ${short()} - ${
process.env.GITHUB_RUN_ID ? `CI: ${process.env.GITHUB_RUN_ID}` : 'Local'
}`,
// TODO - https://github.com/transcend-io/penumbra/issues/249
// // A secure context must be used for `crypto.subtle` to be defined
// acceptInsecureCerts: 'true',
// acceptSslCerts: 'true',
// A secure context must be used for `crypto.subtle` to be defined
acceptInsecureCerts: 'true',
acceptSslCerts: 'true',
},

// define browsers
Expand Down
15 changes: 7 additions & 8 deletions karma.global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const webpackConfig = require('./webpack.prod.js');
// const { serverCrt, serverKey } = require('./karma-certificate');
const { serverCrt, serverKey } = require('./karma-certificate');

module.exports = (config) => ({
// base path that will be used to resolve all patterns (eg. files, exclude)
Expand Down Expand Up @@ -58,13 +58,12 @@ module.exports = (config) => ({
reporters: [{ type: 'lcov' }],
},

// TODO - https://github.com/transcend-io/penumbra/issues/249
// // Create a secure context so `crypto.subtle` is defined
// httpsServerOptions: {
// key: Buffer.from(serverKey, 'base64').toString('utf-8'),
// cert: Buffer.from(serverCrt, 'base64').toString('utf-8'),
// },
// protocol: 'https:',
// Create a secure context so `crypto.subtle` is defined
httpsServerOptions: {
key: Buffer.from(serverKey, 'base64').toString('utf-8'),
cert: Buffer.from(serverCrt, 'base64').toString('utf-8'),
},
protocol: 'https:',

// web server port
port: 9876,
Expand Down