fix(edit): Ignore id tags when calculating highlighted line in edit view#302
Open
wilywyrm wants to merge 3 commits intotranxuanthang:mainfrom
Open
fix(edit): Ignore id tags when calculating highlighted line in edit view#302wilywyrm wants to merge 3 commits intotranxuanthang:mainfrom
wilywyrm wants to merge 3 commits intotranxuanthang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The EditLyrics view naively calculates the line to highlight without taking into consideration if lines are not a timed lyric line (such as ID tags like
[lang: <language>]or an empty newline). This causes a mismatch during playback if there are any non-time lines in the document.The non-edit view pre-parses the document to strip out display ID tags and so does not have the same problem.
Note that the ID tag is incorrectly highlighted when playback has already progressed past the first lyric line's timestamp.
Implementation