Bawahakim/logger level #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
logLevelsoption currently seem useless when usingSentryServiceas the logger. It would be convenient if we could specify the log levels to log.Solution
Uses the build in
logLevelsoption to decide if a method should log or not (including sending to sentry/adding breadcrumbs)Caveat
The
SentryServiceInstancemethod returns a new SentryService in which the options are undefined. To fix, it was necessary to set the instance in the constructor (when the options have been specified). This seems to work well but unsure of any side-effects within the package. Cherry-picked from #5