Show a helpful error message if debug mode is not enabled

.travis.yml

@@ -8,9 +8,9 @@ rvm: 2.6.5
 script: "bundle exec rake knapsack:rspec"
 
 addons:
-  - snaps:
-    - name: docker
-      channel: latest/beta
+  snaps:
+  - name: docker
+    channel: latest/beta
 
 env:
   global:
@@ -38,4 +38,4 @@ jobs:
       install: echo skip
       before_script: echo skip
       script: make ship
-      if: commit_message =~ /ship:docker/ OR env(SHIP_DOCKER) = true or branch = master
+      if: (commit_message =~ /ship:docker/ OR env(SHIP_DOCKER) = true or branch = master) and type != pull_request

lib/travis/api/v3.rb

@@ -32,6 +32,7 @@ def location(env)
       AlreadySyncing      = ClientError        .create('sync already in progress', status: 409)
       BuildAlreadyRunning = ClientError        .create('build already running, cannot restart', status: 409)
       BuildNotCancelable  = ClientError        .create('build is not running, cannot cancel', status: 409)
+      DebugUnavailable    = ClientError        .create('debug mode not enabled',  status: 403)
       DuplicateResource   = ClientError        .create('resource already exists', status: 409)
       EntityMissing       = NotFound           .create(type: 'not_found')
       InsufficientAccess  = ClientError        .create(status: 403)

lib/travis/api/v3/services/job/debug.rb

@@ -6,9 +6,9 @@ class Services::Job::Debug < Service
 
     def run
       @job = check_login_and_find(:job)
-      raise WrongCredentials unless job.repository.debug_tools_enabled?
-
       access_control.permissions(job).debug!
+      raise DebugUnavailable unless job.repository.debug_tools_enabled?
+
       return repo_migrated if migrated?(job.repository)
 
       job.debug_options = debug_data

spec/v3/services/job/debug_spec.rb

@@ -78,8 +78,8 @@
             example { expect(last_response.status).to be == 403 }
             example { expect(JSON.load(body)).to include(
               "@type"         => "error",
-              "error_message" => "access denied",
-              "error_type" => "wrong_credentials"
+              "error_message" => "debug mode not enabled",
+              "error_type" => "debug_unavailable"
             )}
           end
         end