Skip to content

Fix null pointer exception when importing program members multithread. #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix null pointer exception when importing program members multithread. #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/embulk/input/marketo/delegate/ProgramMembersBulkExtractInputPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
public class ProgramMembersBulkExtractInputPlugin extends MarketoBaseInputPluginDelegate<ProgramMembersBulkExtractInputPlugin.PluginTask>
{
private final Logger logger = LoggerFactory.getLogger(getClass());
private final Object pageBuilderLock = new Object();

public interface PluginTask extends MarketoBaseInputPluginDelegate.PluginTask, CsvTokenizer.PluginTask
{
Expand Down Expand Up @@ -214,7 +215,9 @@ private Future<?> createFutureTask(PluginTask task, RecordImporter recordImporte
while (csvRecords.hasNext()) {
Map<String, String> csvRecord = csvRecords.next();
ObjectNode objectNode = MarketoUtils.OBJECT_MAPPER.valueToTree(csvRecord);
recordImporter.importRecord(new AllStringJacksonServiceRecord(objectNode), pageBuilder);
synchronized (pageBuilderLock) {
recordImporter.importRecord(new AllStringJacksonServiceRecord(objectNode), pageBuilder);
}
imported = imported + 1;
}

Expand Down