Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for import attributes #277

Closed
wants to merge 1 commit into from

Conversation

mskelton
Copy link
Contributor

Re-opening #238 given the new import attributes spec is at stage 3.

tc39/ecma262#3057

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@mskelton mskelton mentioned this pull request Dec 14, 2023
6 tasks
@amaanq amaanq mentioned this pull request Feb 1, 2024
@amaanq
Copy link
Member

amaanq commented Feb 1, 2024

Hi @mskelton, I cherry picked your changes onto #291, thank you!

@amaanq amaanq closed this Feb 1, 2024
@mskelton mskelton deleted the import-attributes branch February 1, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants