-
-
Notifications
You must be signed in to change notification settings - Fork 159
Simplify try statement, accept missing else/except/finally #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Smit Barmase <[email protected]>
If you update the parser to ABI 15, you also need to update the bindings to match ( |
|
I'm using the latest version of Tree-sitter CLI via |
Didn't you just release a new version? ;) It looks like you're using a distro build of v0.25.4 (distro I'm guessing, but the version is right there in the diff.) |
Yeah, but the same error occurred before that; the problem is that you don't get a BUILD SHA apparently if you |
(I do agree FWIW; it can be useful info but in combination with the overbearing workflows it's obnoxious.) |
I get the good intention behind failing the build if the parser changed, but combined with the build sha thing, it's causing problems. It's nobody's fault, just observing some pain points that have arisen with Tree-sitter because of a few good ideas combining badly. |
Maybe the workflow can ignore the first line of that diff ( |
(Not a maintainer here so I can't push to your PR; otherwise it'd be an easy fix for me.) |
1377915
to
260dd63
Compare
This makes the parser more useful for editors, since the
try_statement
will still be identified, even if it's incomplete.