Skip to content

fix: Closure parameters can have trailing commas #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Closure parameters can have trailing commas #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions grammar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,7 @@ module.exports = grammar({
$._pattern,
$.parameter,
)),
optional(','),
'|',
),

Expand Down
31 changes: 30 additions & 1 deletion test/corpus/expressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,7 +1258,7 @@ h(|| -> i { j });
(identifier)))))))

================================================================================
Closures with typed parameteres
Closures with typed parameters
================================================================================

a.map(|b: usize| b.push(c));
Expand All @@ -1284,6 +1284,35 @@ a.map(|b: usize| b.push(c));
(arguments
(identifier))))))))


================================================================================
Closure parameters can have a trailing comma
================================================================================

a.map(|b: usize,| b.push(c));

--------------------------------------------------------------------------------

(source_file
(expression_statement
(call_expression
(field_expression
(identifier)
(field_identifier))
(arguments
(closure_expression
(closure_parameters
(parameter
(identifier)
(primitive_type)))
(call_expression
(field_expression
(identifier)
(field_identifier))
(arguments
(identifier))))))))


================================================================================
Generators
================================================================================
Expand Down