feat(webdav): add bearer_token_command for dynamic token acquisition

[GreenHatHG]

see: treeverse/dvc#10917

[skshetry]

Thank you for contributing. This looks good overall. One question. Could you also add a few tests to exercise the BearerAuth code path? That would help ensure it works correctly and does not regress.

Also, contribution to dvc repositories now require accepting the CLA: https://cla-assistant.io/treeverse/dvc-webdav. It'd be great if you could do that. Thanks.

[CLAassistant]

All committers have signed the CLA.

[GreenHatHG]

@skshetry
I've added the test cases covering BearerAuth as requested.
Also, to ensure end-to-end stability, I've added a corresponding integration test in the dvc repo (treeverse/dvc#10917).

[skshetry]

I don’t see the need for tests beyond this line, especially the concurrent one. I doubt they would help catch the issue if it occurs in the future.

When I requested tests, my only concern was verifying that the command is called and behaves as expected: setting the token in the header on success and raising an error when it exits with a failure. Another goal was to ensure it works on Windows, though the current test doesn’t cover that since all subprocess calls are mocked and I’m okay with that.

I appreciate that you also added tests for token refresh, but the rest feels excessive.

[GreenHatHG]

Thanks for the feedback!
I agree that the test suite was getting a bit heavy. I've removed test_auth_flow_failure_after_refresh and the other edge-case tests as suggested.
It looks much cleaner now. Please let me know if there's anything else needed.

[GreenHatHG]

@skshetry
It seems the GitHub Actions workflow is waiting for approval to run. Could you please hit the "Approve and run" button when you have a moment? Thanks!

[skshetry]

@GreenHatHG, looks like we don't have pytest-mock installed here. Please feel add them to tests dependencies in pyproject.toml.

[GreenHatHG]

@GreenHatHG, looks like we don't have pytest-mock installed here. Please feel add them to tests dependencies in pyproject.toml.

Fixed in the latest commit.
All CI checks have passed. The remaining conversation threads are addressed in the code.
I think this is ready to be merged whenever you have a moment.

[skshetry]

Thank you for contributing!