Guard repeat comm-prefs setup and cache setup state in memory#10435
Open
nopcoder wants to merge 1 commit into
Open
Guard repeat comm-prefs setup and cache setup state in memory#10435nopcoder wants to merge 1 commit into
nopcoder wants to merge 1 commit into
Conversation
SetupCommPrefs now rejects a repeat call with 409 instead of silently overriding stored preferences. Cache the initialized and comm_prefs_set states in memory once observed true so the UI's repeated setup-state polls don't hit KV on every check.
nopcoder
added
exclude-changelog
github-actions
Bot
added
area/testing
N-o-Z
requested changes
Jun 8, 2026
N-o-Z
left a comment
N-o-Z
left a comment
Contributor
There was a problem hiding this comment.
I can't understand this rationale from a product standpoint.
I would expect users to be able to opt in - in case they initially opted out. This seems like a business interest as well.
I expected this change to check if we're post setup - and if we are to gate this API with an authorization check (e.g.: admin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetupCommPrefsnow returns 409 Conflict on a repeat call instead of silently overriding stored communication preferences.initializedandcomm_prefs_setstates in memory (sticky once observed true) so the UI's repeated setup-state polls don't hit KV on every check.