Upgrade golangci-lint to v2 #8986

nopcoder · 2025-04-27T06:20:18Z

Fixed some of the lint issues - plan to enable lint on tests and more linters after this PR.
The github-actions output format was removed - will consider to use their action to run the lint

handle some of the lint errors next PR will enable more on test code

github-actions · 2025-04-27T06:27:58Z

E2E Test Results - DynamoDB Local - Local Block Adapter

github-actions · 2025-04-27T06:28:52Z

E2E Test Results - Quickstart

no longer supported

arielshaqed

This is really neat! But some of the new(?) linter features are not so good. Please see comments inlines. I did not go over the second half, if it's OK with you I would rather finish handling these comments and then have another round.

arielshaqed · 2025-04-30T07:09:24Z

cmd/lakectl/cmd/import.go

@@ -97,15 +97,17 @@ var importCmd = &cobra.Command{
 			case <-ticker.C:
 				statusResp, err = client.ImportStatusWithResponse(ctx, toURI.Repository, toURI.Ref, &apigen.ImportStatusParams{Id: importID})
 				DieOnErrorOrUnexpectedStatusCode(statusResp, err, http.StatusOK)
-				status := statusResp.JSON200
-				if status == nil {
+				if statusResp.JSON200 == nil {


I don't understand this "fix". It seems longer, more reasonable, and easier to get wrong when code is notified. (TBF, if this flags a "can be nil" warning, any future breakage will flag it again...)

The fix was related to missing nil check with status.IngestedObjects. The line you marked is related to the change I made where we verify the statusResp.JSON200 nil before assign it to local variable where the old code assigned it first?

Let me know if moving the assignment first will make it clear or I missed anything and the issue with something else.

Yeah, I'd just prefer the assignment first.

arielshaqed · 2025-04-30T07:11:01Z

cmd/lakectl/cmd/local_init.go

@@ -80,7 +80,7 @@ func localInit(ctx context.Context, dir string, remote *uri.URI, force, updateIg
 		ignoreFile, err := git.Ignore(dir, []string{dir}, []string{filepath.Join(dir, local.IndexFileName)}, local.IgnoreMarker)
 		if err == nil {
 			fmt.Println("Location added to", ignoreFile)
-		} else if !(errors.Is(err, giterror.ErrNotARepository) || errors.Is(err, giterror.ErrNoGit)) {
+		} else if !errors.Is(err, giterror.ErrNotARepository) && !errors.Is(err, giterror.ErrNoGit) {


Why is this better? Can we turn this longer off?
I definitely prefer the former (but not enough to require it). For instance, it is easier to refactor into a function isErrNotVersiomed. In general, negatives are confusing, best use as few of them as possible.

One of the staticchecks linter try to apply de morgan's law on expressions that starts like !(...)
Will disable the check.

moving the status assignment before the check

arielshaqed · 2025-04-30T07:15:07Z

cmd/lakectl/cmd/root.go

@@ -329,7 +329,7 @@ func getSyncArgs(args []string, requireRemote bool, considerGitRoot bool) (remot
 		gitRoot, err := git.GetRepositoryPath(localPath)
 		if err == nil {
 			localPath = gitRoot
-		} else if !(errors.Is(err, giterror.ErrNotARepository) || errors.Is(err, giterror.ErrNoGit)) { // allow support in environments with no git
+		} else if !errors.Is(err, giterror.ErrNotARepository) && !errors.Is(err, giterror.ErrNoGit) { // allow support in environments with no git


Same here, don't like this lint

cmd/lakefs/cmd/setup.go

arielshaqed · 2025-04-30T07:17:58Z

esti/esti_utils.go

@@ -668,7 +668,11 @@ func checkFileWasGarbageCollected(t *testing.T, presignedURLs map[string]string,
 	if err != nil {
 		t.Fatalf("%s, expected no error, got err=%s", "Http request to presigned url", err)
 	}
-	defer r.Body.Close()
+	defer func() {
+		if err := r.Body.Close(); err != nil {


This is silly for a read, because Close cannot fail. But if it did, I would want to fail the test.
Can we nolint this here, with some content?

revert and check how we can exclude this one

arielshaqed · 2025-04-30T07:22:48Z

esti/s3_gateway_test.go

@@ -1058,13 +1062,8 @@ func TestDeleteObjects(t *testing.T) {
 	ctx, _, repo := setupTest(t)
 	defer tearDownTest(repo)
 	const numOfObjects = 10
-	identifiers := make([]types.ObjectIdentifier, 0, numOfObjects)


Oh wow, actual code analysis for Go. Neat!

we really need to enable linters on test code

Yes, PLEASE!

arielshaqed · 2025-04-30T07:23:37Z

pkg/actions/kv_task_results_iterator_test.go

@@ -36,7 +36,7 @@ func TestTaskResultsIterator(t *testing.T) {
 		},
 		{
 			name:  "after out of range",
-			runID: rand.Intn(100),
+			runID: rand.Intn(100), //nolint:gosec


Can we disable gosec in tests? Preferably just the "pseudorandom numbers" thing?

reverted. will address it when enable linters on test code.

pkg/actions/lua/storage/gcloud/gcs.go

arielshaqed · 2025-04-30T07:24:37Z

pkg/actions/service_test.go

@@ -34,12 +34,12 @@ const (
 )

 type ActionStatsMockCollector struct {
-	Hits map[string]int
+	Hits map[string]uint64


What? No, I thought the whole idea was to avoid unsigned arithmetic wherever possible.

To quote some people who think they know Go:

When you need an integer value you should use int unless you have a specific reason to use a sized or unsigned integer type.
(My emphasis)

For counters and sizes signed integers are almost always better, they avoid making silly errors such as

var ( counter, max uint64 ) max = max.MaxUint64 - 3 // ... // Check if we have room for 5 more if counter + 5 < max { // Gotcha! If counter == max-1 then counter + 5 == 1 and we're in here. }

this is the mock collector - I've updated the storage data type to match the interface CollectEvents(ev stats.Event, count uint64) where we collect the counters.

Ouch, so the interface is also bad. Anyway clearly out of scope for this PR 😢

arielshaqed · 2025-04-30T08:28:53Z

pkg/api/controller.go

@@ -317,7 +317,8 @@ func (c *Controller) UploadPart(w http.ResponseWriter, r *http.Request, body api

 func (c *Controller) UploadPartCopy(w http.ResponseWriter, r *http.Request,
 	body apigen.UploadPartCopyJSONRequestBody, dstRepository string, branch string, uploadID string, partNumber int,
-	params apigen.UploadPartCopyParams) {
+	params apigen.UploadPartCopyParams,


If different formatting is now required then gofmt should enforce it.

this formatting is extra done because of my formatter - it is not required.
it is compatible with gofmt.

* initial alter impl * fix sql * execute statement * docs * param order * docs

Add details for new features, bug fixes, and improvements in v1.55.0. Highlights include repository/branch listing by prefix, enhanced pagination, security updates, and UI fixes.

* lakefsfs listStatus - Skip stat object on empty path * Add test for list status on root

* Enhance repository tree layout and link behavior Added inline styles to improve layout responsiveness and prevent overflow issues. Updated link paths to include references in the query parameters for better navigation. Minor adjustments ensure consistent component rendering and functionality. * Refactor repository layout and adjust CSS for flexibility Updated `RepoNav` to include reference handling for breadcrumbs, enabling better navigation with references. Adjusted global CSS and tree component to remove redundant `min-width` specification, ensuring consistent layout behavior.

* Install lakectl and lakefs binary wrappers * include Docker run option * refactor and fix linter * linter * better avoidance of recursive execution * ignore python build artifacts * execute module and explicit download * subcommands for lakefs and lakectl * docs fixes * seperate commands * support venv on windows * fix docs * remove shebangs * simplify quickstart flow

* Re-release the python HL SDK with minor version bump * fix spelling

- applyed the same linter configuration - revert all `if` invert - revert some of the defer anonymous func

github-actions · 2025-05-03T18:21:09Z

🎊 PR Preview 38e77c9 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8986.surge.sh

🕐 Build time: 0.01s

_{🤖 By surge-preview}

handle some of the lint errors next PR will enable more on test code

no longer supported

nopcoder · 2025-05-03T18:42:28Z

@arielshaqed thanks - I've revert the relevant changes, kept some comments and rewrote the configuration as yml without adding anything new, just disabled the "Apply De Morgan’s law" one

arielshaqed

THANKS!

arielshaqed · 2025-05-04T07:56:24Z

cmd/lakectl/cmd/import.go

@@ -97,15 +97,17 @@ var importCmd = &cobra.Command{
 			case <-ticker.C:
 				statusResp, err = client.ImportStatusWithResponse(ctx, toURI.Repository, toURI.Ref, &apigen.ImportStatusParams{Id: importID})
 				DieOnErrorOrUnexpectedStatusCode(statusResp, err, http.StatusOK)
-				status := statusResp.JSON200
-				if status == nil {
+				if statusResp.JSON200 == nil {


Yeah, I'd just prefer the assignment first.

arielshaqed · 2025-05-04T07:57:07Z

esti/s3_gateway_test.go

@@ -1058,13 +1062,8 @@ func TestDeleteObjects(t *testing.T) {
 	ctx, _, repo := setupTest(t)
 	defer tearDownTest(repo)
 	const numOfObjects = 10
-	identifiers := make([]types.ObjectIdentifier, 0, numOfObjects)


Yes, PLEASE!

pkg/actions/lua/storage/gcloud/gcs.go

arielshaqed · 2025-05-04T07:58:01Z

pkg/actions/service_test.go

@@ -34,12 +34,12 @@ const (
 )

 type ActionStatsMockCollector struct {
-	Hits map[string]int
+	Hits map[string]uint64


Ouch, so the interface is also bad. Anyway clearly out of scope for this PR 😢

upgrade golangci-lint to v2

528886a

handle some of the lint errors next PR will enable more on test code

nopcoder added area/testing Improvements or additions to tests infrastructure build, deploy and release processes labels Apr 27, 2025

nopcoder self-assigned this Apr 27, 2025

revert interface spelling fix

dab1296

remove golangci-lint output format

80c4ab5

no longer supported

nopcoder added the exclude-changelog PR description should not be included in next release changelog label Apr 27, 2025

nopcoder requested a review from a team April 27, 2025 08:49

nopcoder added the minor-change Used for PRs that don't require issue attached label Apr 27, 2025

arielshaqed requested changes Apr 30, 2025

View reviewed changes

nopcoder and others added 18 commits May 3, 2025 19:54

Update mount.md remove only read-only (#8984)

40def3b

IAM mount: lakectl config (#8982)

a20b343

Spark Client StorageID support (#8918)

0605ffe

Get installation ID from license manager (#8985)

24a5fdc

Lua Hooks: databricks alter table (#8976)

0371f85

* initial alter impl * fix sql * execute statement * docs * param order * docs

Update CHANGELOG for v1.55.0 release (#8987)

a28a267

Add details for new features, bug fixes, and improvements in v1.55.0. Highlights include repository/branch listing by prefix, enhanced pagination, security updates, and UI fixes.

Add lakefs v1.55.0 release version (#8988)

b2b7a59

lakefsfs listStatus - Skip stat object on empty path (#8989)

5c29fa6

* lakefsfs listStatus - Skip stat object on empty path * Add test for list status on root

Update python wrapper changelog before release (#8999)

1f28af3

Re-release the python HL SDK with minor version bump (#9000)

71a3f93

* Re-release the python HL SDK with minor version bump * fix spelling

reaplce secrets-detector package with treeverse fork (#9001)

0294100

Spark metadata changelog for version v0.14.2 (#9003)

8e6098c

Bump metadata client version (#9004)

cbbf636

Changelog for lakeFSFS version 0.2.5 (#9005)

de2b6fd

Update Docs with spark version bump (#9006)

b42b1bc

Update Docs with hadoop lakeFS version bump (#9008)

1f6aaac

N-o-Z and others added 2 commits May 3, 2025 19:54

Fix KV driver close (#9011)

2c020f5

Apply code review changes

38e77c9

- applyed the same linter configuration - revert all `if` invert - revert some of the defer anonymous func

nopcoder added 6 commits May 3, 2025 21:25

upgrade golangci-lint to v2

9143161

handle some of the lint errors next PR will enable more on test code

revert interface spelling fix

4e0cc90

remove golangci-lint output format

c7cec03

no longer supported

Merge branch 'master' into chore/golangci-lint

a349343

remove unused return

a1b1aa3

revert changes after review

2066bcc

comment the check we disabled

536deab

nopcoder requested a review from arielshaqed May 4, 2025 07:39

arielshaqed approved these changes May 4, 2025

View reviewed changes

apply code review feedback

b616f08

nopcoder enabled auto-merge (squash) May 4, 2025 08:01

nopcoder merged commit ed66469 into master May 4, 2025
41 checks passed

nopcoder deleted the chore/golangci-lint branch May 4, 2025 08:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade golangci-lint to v2 #8986

Upgrade golangci-lint to v2 #8986

nopcoder commented Apr 27, 2025 •

edited

Loading

github-actions bot commented Apr 27, 2025

github-actions bot commented Apr 27, 2025

arielshaqed left a comment

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

arielshaqed May 4, 2025

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

nopcoder May 4, 2025

arielshaqed Apr 30, 2025

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

arielshaqed May 4, 2025

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

arielshaqed Apr 30, 2025

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

arielshaqed May 4, 2025

arielshaqed Apr 30, 2025

nopcoder May 3, 2025

github-actions bot commented May 3, 2025 •

edited

Loading

nopcoder commented May 3, 2025

arielshaqed left a comment

arielshaqed May 4, 2025

arielshaqed May 4, 2025

arielshaqed May 4, 2025

Upgrade golangci-lint to v2 #8986

Upgrade golangci-lint to v2 #8986

Conversation

nopcoder commented Apr 27, 2025 • edited Loading

github-actions bot commented Apr 27, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

github-actions bot commented Apr 27, 2025

E2E Test Results - Quickstart

arielshaqed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 3, 2025 • edited Loading

nopcoder commented May 3, 2025

arielshaqed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nopcoder commented Apr 27, 2025 •

edited

Loading

github-actions bot commented May 3, 2025 •

edited

Loading