Make GC work with EMR 7.0.0 #9013
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
nopcoder
requested changes
May 15, 2025
| @@ -127,7 +132,7 @@ object StorageUtils { | |||
|
|
|||
| private def initializeS3Client( | |||
| configuration: ClientConfiguration, | |||
| credentialsProvider: Option[AWSCredentialsProvider], | |||
| credentialsProvider: Option[Any], | |||
There was a problem hiding this comment.
Is it possible to keep interface of the same type that builderWithEndpoint.withCredentials accepts instead of general object?
idanovo
had a problem deploying
to
Treeverse signing
GitHub Actions
Failure
…rk-client-emr-7
nopcoder
requested changes
May 15, 2025
nopcoder
approved these changes
May 18, 2025
| } | ||
| } catch { | ||
| case e: io.treeverse.jpebble.BadFileFormatException => | ||
| logger.error(s"File format validation failed for: ${gravelerSplit.path}", e) |
There was a problem hiding this comment.
nit; failed to read sstable, bad file format
Isan-Rivkin
requested changes
May 20, 2025
| } | ||
|
|
||
| // Check for Hadoop's assumed role configuration | ||
| val roleArn = System.getProperty("spark.hadoop.fs.s3a.assumed.role.arn") |
There was a problem hiding this comment.
please move to consts file we have
Isan-Rivkin
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.