Skip to content

Add GeoJSON file rendering support and amend preview support in ObjectsDiff #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ben-El
Copy link
Contributor

@Ben-El Ben-El commented May 5, 2025

Closes #9017

Introduced a dedicated GeoJSONRenderer and associated file type handling for GeoJSON files. Updated file renderer logic to recognize and process GeoJSON, enabling better visualization and support for this format.
Also, changing the objectDiff preview to show the json diff, instead of the map itself.

Part of issue: #9012

Related previous PR: #8996

ObjectsDiff preview:
image

Object preview:
image

Introduced a dedicated `GeoJSONRenderer` and associated file type handling for GeoJSON files. Updated file renderer logic to recognize and process GeoJSON, enabling better visualization and support for this format.
@Ben-El Ben-El requested a review from itaigilo May 5, 2025 06:20
@Ben-El Ben-El added the include-changelog PR description should be included in next release changelog label May 5, 2025
Copy link

github-actions bot commented May 5, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed, 1 skipped

Copy link

github-actions bot commented May 5, 2025

E2E Test Results - Quickstart

12 passed

@Ben-El Ben-El requested a review from a team May 5, 2025 06:39
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point,
Missed that on my previous review.

Please make sure it's reverted properly.

Replaced `diffViewersByExtension` with a simplified `supportedReadableFormats` array and updated logic for determining readable formats. This streamlines the code and improves maintainability while preserving functionality.
@Ben-El Ben-El requested a review from itaigilo May 5, 2025 09:17
@Ben-El Ben-El added the area/UI Improvements or additions to UI label May 5, 2025
@Ben-El Ben-El merged commit e78b9e1 into master May 5, 2025
45 of 48 checks passed
@Ben-El Ben-El deleted the add-geojson-file-rendering-support-and-fix-objectDiff branch May 5, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GeoJSON file rendering support and amend preview support in ObjectsDiff
2 participants