Skip to content

Added documentation for licenses in lakeFS Enterprise to the public docs #9270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 17, 2025

Conversation

Annaseli
Copy link
Contributor

@Annaseli Annaseli commented Jul 8, 2025

Closes #9269

  1. Added licensing documentation for lakeFS Enterprise to the public docs.
    Note that most of the content is collapsed within toggle boxes (using ??? info) to improve readability by hiding additional details, which users can expand as needed.

  2. Added missing links to the “Install” documentation page.

  3. Applied additional styling to the page.

@Annaseli Annaseli requested review from ozkatz and a team July 8, 2025 12:28
@Annaseli Annaseli changed the title Added documentation for licenses in lakeFS Enterprise to the docs Added documentation for licenses in lakeFS Enterprise to the public docs Jul 8, 2025
Copy link

github-actions bot commented Jul 8, 2025

📚 Documentation preview at https://pr-9270.docs-lakefs-preview.io/

(Updated: 7/17/2025, 11:40:11 PM - Commit: 6a9e33f)

@Annaseli Annaseli added include-changelog PR description should be included in next release changelog exclude-changelog PR description should not be included in next release changelog and removed exclude-changelog PR description should not be included in next release changelog labels Jul 8, 2025
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my 2 cents.
However I think the final decision should be by product

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog and removed include-changelog PR description should be included in next release changelog labels Jul 10, 2025
@N-o-Z
Copy link
Member

N-o-Z commented Jul 10, 2025

@Annaseli General comment - we do not add the include-changelog label for changes in documentation, tests or infrastructure. (You can find the guideline in the lakeFS release document

Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this is really weird Markdown. Confused but not blocking.

@@ -3,16 +3,15 @@ title: Install
description: lakeFS Enterprise Installation Guide
---

# Install
# **Install**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we try to add styles to markdown headings like this. In fact, AFAIK:

  • There should be no difference between the appearance of these two style, the first should be <h1>Install</h1> and the second should be <h1><b>Install</b></h1>. These are generally styled the same. Similarly for ##.
  • Other headers in our docs do not receive this treatment.

Why are these headings different?

This is what these headings look like on the preview:
preview rendered on FF, h1 is less bold than h2
On FF, h1 appears less bold than h2. We may have a CSS problem, but let's not fix it separately on each page.

Copy link
Contributor Author

@Annaseli Annaseli Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielshaqed
Got it, I’ve reverted the change.
I thought the bold headings improved readability and overall appearance, which is why I made the adjustment. However, I agree it’s not ideal to apply this styling change on a single page only.

Before my modification, this is how it looked in Chrome:
image

After my modification, it appeared like this in Chrome:
image

…nse requirement just below the ### lakeFS Enterprise License title.
@Annaseli Annaseli requested review from N-o-Z and arielshaqed July 16, 2025 15:35
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly great! I love the troubleshooting section :)

Some markdown nitpicks that if addressed, could make the page more accessible and allow for hot linking to specific sections.

> **Note**: The token can be decoded using any JWT decoding tool to view the license information.

??? question "Troubleshooting"
- **Server Won't Start**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a list, use ##### (h5) or ###### (h6) - will not show up in the TOC but will be hot-linkable.

Copy link
Contributor Author

@Annaseli Annaseli Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozkatz
Got it, when using the h5 heading, it looks like this:

image

and the title does appear in the TOC:

image

When using the h6 heading, it looks like this: and the title does not appear in the TOC.

image

I think the h5 is better, what do you think?

@Annaseli Annaseli requested a review from ozkatz July 17, 2025 12:28
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great.

My comments are mostly Markdown styling. It's better to use semantic headings over styling regular text to look like a header. If we're unhappy with how headings look, let's use semantic markdown and improve styles in CSS! Better for accessibility and easier to read and maintain.

#### **Licensed Features**
The following lakeFS Enterprise features must be included in the lakeFS Enterprise license in order to be available:

<u>Authentication & Authorization</u>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<u>Authentication & Authorization</u>
##### Authentication & Authorization

- [SCIM (System for Cross-domain Identity Management)](../../howto/scim.md)
- [IAM (Identity and Access Management) Role Authentication](../../security/external-principals-aws.md)

<u>Advanced Functionality</u>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<u>Advanced Functionality</u>
##### Advanced Functionality

lakeFS Enterprise server and paid features. A license is tied to a specific installation via an installation ID, and to
a specific organization via an organization ID.

<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<br>

3. <u>Configure lakeFS Enterprise Server</u>
1. Save the license token to a file.
2. Provide the file path in the lakeFS Enterprise configuration file:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

}
```

> **Note**: The token can be decoded using any JWT decoding tool to view the license information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Note**: The token can be decoded using any JWT decoding tool to view the license information.
The returned token can be decoded using any JWT decoding tool to view the license information.


> **Note**: The token can be decoded using any JWT decoding tool to view the license information.

<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<br>

<br>

#### **License Monitoring & Updates**
<u>Updating Your License</u>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<u>Updating Your License</u>
##### Updating Your License

- <u>Validation and Expiry Check:</u> Occurs periodically to verify license validity and expiry.
- <u>File Monitoring:</u> The server checks periodically to detect license file changes so that when the license token gets updated in the file, there is no need to restart the server and the license updates automatically.

<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<br>


<br>

#### **License Monitoring & Updates**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### **License Monitoring & Updates**
#### License Monitoring & Updates


<br>

#### **Troubleshooting**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### **Troubleshooting**
#### Troubleshooting

@Annaseli
Copy link
Contributor Author

Thanks! Looks great.

My comments are mostly Markdown styling. It's better to use semantic headings over styling regular text to look like a header. If we're unhappy with how headings look, let's use semantic markdown and improve styles in CSS! Better for accessibility and easier to read and maintain.

@ozkatz
ok, yes, I think it's a good idea to improve our CSS for styling the headings in the docs. I'll look into it next week.

@Annaseli Annaseli merged commit d677e6b into master Jul 17, 2025
42 checks passed
@Annaseli Annaseli deleted the docs/add-documentation-for-licenses-in-docs branch July 17, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To add documentation for licenses in lakeFS Enterprise to the public docs
4 participants