-
Notifications
You must be signed in to change notification settings - Fork 382
Added documentation for licenses in lakeFS Enterprise to the public docs #9270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📚 Documentation preview at https://pr-9270.docs-lakefs-preview.io/ (Updated: 7/17/2025, 11:40:11 PM - Commit: 6a9e33f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my 2 cents.
However I think the final decision should be by product
@Annaseli General comment - we do not add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this is really weird Markdown. Confused but not blocking.
@@ -3,16 +3,15 @@ title: Install | |||
description: lakeFS Enterprise Installation Guide | |||
--- | |||
|
|||
# Install | |||
# **Install** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we try to add styles to markdown headings like this. In fact, AFAIK:
- There should be no difference between the appearance of these two style, the first should be
<h1>Install</h1>
and the second should be<h1><b>Install</b></h1>
. These are generally styled the same. Similarly for##
. - Other headers in our docs do not receive this treatment.
Why are these headings different?
This is what these headings look like on the preview:
On FF, h1 appears less bold than h2. We may have a CSS problem, but let's not fix it separately on each page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielshaqed
Got it, I’ve reverted the change.
I thought the bold headings improved readability and overall appearance, which is why I made the adjustment. However, I agree it’s not ideal to apply this styling change on a single page only.
…nse requirement just below the ### lakeFS Enterprise License title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly great! I love the troubleshooting section :)
Some markdown nitpicks that if addressed, could make the page more accessible and allow for hot linking to specific sections.
> **Note**: The token can be decoded using any JWT decoding tool to view the license information. | ||
|
||
??? question "Troubleshooting" | ||
- **Server Won't Start** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a list, use #####
(h5) or ######
(h6) - will not show up in the TOC but will be hot-linkable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ozkatz
Got it, when using the h5 heading, it looks like this:

and the title does appear in the TOC:

When using the h6 heading, it looks like this: and the title does not appear in the TOC.

I think the h5 is better, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great.
My comments are mostly Markdown styling. It's better to use semantic headings over styling regular text to look like a header. If we're unhappy with how headings look, let's use semantic markdown and improve styles in CSS! Better for accessibility and easier to read and maintain.
#### **Licensed Features** | ||
The following lakeFS Enterprise features must be included in the lakeFS Enterprise license in order to be available: | ||
|
||
<u>Authentication & Authorization</u> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<u>Authentication & Authorization</u> | |
##### Authentication & Authorization |
- [SCIM (System for Cross-domain Identity Management)](../../howto/scim.md) | ||
- [IAM (Identity and Access Management) Role Authentication](../../security/external-principals-aws.md) | ||
|
||
<u>Advanced Functionality</u> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<u>Advanced Functionality</u> | |
##### Advanced Functionality |
lakeFS Enterprise server and paid features. A license is tied to a specific installation via an installation ID, and to | ||
a specific organization via an organization ID. | ||
|
||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br> |
3. <u>Configure lakeFS Enterprise Server</u> | ||
1. Save the license token to a file. | ||
2. Provide the file path in the lakeFS Enterprise configuration file: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
``` | ||
|
||
> **Note**: The token can be decoded using any JWT decoding tool to view the license information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> **Note**: The token can be decoded using any JWT decoding tool to view the license information. | |
The returned token can be decoded using any JWT decoding tool to view the license information. |
|
||
> **Note**: The token can be decoded using any JWT decoding tool to view the license information. | ||
|
||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br> |
<br> | ||
|
||
#### **License Monitoring & Updates** | ||
<u>Updating Your License</u> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<u>Updating Your License</u> | |
##### Updating Your License |
- <u>Validation and Expiry Check:</u> Occurs periodically to verify license validity and expiry. | ||
- <u>File Monitoring:</u> The server checks periodically to detect license file changes so that when the license token gets updated in the file, there is no need to restart the server and the license updates automatically. | ||
|
||
<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br> |
|
||
<br> | ||
|
||
#### **License Monitoring & Updates** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### **License Monitoring & Updates** | |
#### License Monitoring & Updates |
|
||
<br> | ||
|
||
#### **Troubleshooting** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### **Troubleshooting** | |
#### Troubleshooting |
@ozkatz |
Closes #9269
Added licensing documentation for lakeFS Enterprise to the public docs.
Note that most of the content is collapsed within toggle boxes (using ??? info) to improve readability by hiding additional details, which users can expand as needed.
Added missing links to the “Install” documentation page.
Applied additional styling to the page.