enhance jwt caching #9481
Open
enhance jwt caching #9481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarYuran
added
exclude-changelog
Isan-Rivkin
requested changes
Sep 3, 2025
Comment on lines
17
to
18
| LakectlDirName = ".lakectl" | ||
| CacheDirName = "cache" |
There was a problem hiding this comment.
- What's the purpose of those directories? Why not just
~/.lakectl_token_cache.json? Or just~/.lakectl/token_cache.json(If you really need a dir) - This is not the right location for such things. It belongs to lakectl code parts, not here.
Comment on lines
31
to
38
| if baseDir == "" { | ||
| var err error | ||
| baseDir, err = os.UserHomeDir() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
| cachePath := filepath.Join(baseDir, lakectlDir, cacheDir) | ||
| cachePath := filepath.Join(baseDir, LakectlDirName, CacheDirName) |
There was a problem hiding this comment.
Those sub diretories are irrelevant for this component.
It doesn't need to force or even know about LakectlDirName, CacheDirName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9480
Got rid of a lot of mess. no sync.Once nor global parameters. I mistakenly thought that abuse commands use separate clients for each iteration but was wrong.