Provide ENSA version info to Wanda #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
enhancement
jamie-suse
force-pushed
the
ensa-versions
branch
2 times, most recently
from
72b2001 to
49e7361
Compare
dottorblaster
suggested changes
Dec 13, 2023
dottorblaster
suggested changes
Dec 13, 2023
assets/js/state/selectors/cluster.js
Outdated
| @@ -62,6 +62,8 @@ export const getClusterSapSystems = createSelector( | |||
| } | |||
| ); | |||
|
|
|||
| export const MIXED_VERSIONS = 'MIXED_VERSIONS'; | |||
There was a problem hiding this comment.
Sorry! The value of this should be just 'mixed_versions', the contract that we have with the checks team is shaped like that 😅
There was a problem hiding this comment.
No worries, will revert 👌
dottorblaster
approved these changes
Dec 13, 2023
jamie-suse
force-pushed
the
ensa-versions
branch
from
7f72b4c to
d9251c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enables the frontend to send ENSA version information about the SAP systems belonging to a certain cluster.
Business Logic
Note that the ENSA version value sent is an aggregated value of the ENSA versions present in the SAP systems for a given cluster.
If a scenario where the ENSA versions are not completely in agreement, then the value
'mixed_versions'is sent.If the ENSA version info is not present for a SAP system, then
'mixed_versions'is sent.Some example scenarios are below:
['ensa1']'ensa1'['ensa2', 'ensa2']'ensa2'['ensa1', 'ensa2']'mixed_versions'['ensa1', undefined]'mixed_versions'[undefined]'mixed_versions'How was this tested?
Added unit tests