Fix ascs ers detection in checks selection #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
bug
nelsonkopliku
force-pushed
the
fix-ascs-ers-detection-in-checks-selection
branch
from
d920f5a to
da5da04
Compare
nelsonkopliku
force-pushed
the
fix-ascs-ers-detection-in-checks-selection
branch
from
da5da04 to
a8d05f1
Compare
|
@abravosuse besides properly detecting and showing ASCS/ERS instead of Unknown, I took the liberty to streamline hana scale up/scale out labels. If that is ok with you, the following change is applied |
SAP literature shows no preference between using the dash or not using it. Therefore this is OK for me. |
dottorblaster
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure that also ASCS/ERS correct cluster type is detected
Also takes care of uniforming
HANA scale-uptoHANA Scale UpHow was this tested?
Tests updated/added
https://2144.prenv.trento.suse.com/clusters/0eac831a-aa66-5f45-89a4-007fbd2c5714/settings