Always keep curly brackets for dynamic paths (#416)

Co-authored-by: William Oprandi <[email protected]>
trevorwang · Nov 16, 2021 · 74bae83 · 74bae83
1 parent 87c8a4d
commit 74bae83
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/generator/lib/src/generator.dart b/generator/lib/src/generator.dart
@@ -339,7 +339,7 @@ class RetrofitGenerator extends GeneratorForAnnotation<retrofit.RestApi> {
     String? definePath = method.peek("path")?.stringValue;
     paths.forEach((k, v) {
       final value = v.peek("value")?.stringValue ?? k.displayName;
-      definePath = definePath?.replaceFirst("{$value}", "\$${k.displayName}");
+      definePath = definePath?.replaceFirst("{$value}", "\${${k.displayName}}");
     });
     return literal(definePath);
   }

diff --git a/generator/test/src/generator_test_src.dart b/generator/test/src/generator_test_src.dart
@@ -132,6 +132,16 @@ abstract class FormUrlEncodedTest {
   Future<String> ip();
 }
 
+@ShouldGenerate(
+  r"/image/${id}_XL.png",
+  contains: true,
+)
+@RestApi()
+abstract class PathTest {
+  @GET("/image/{id}_XL.png")
+  Future<HttpResponse> getImage(@Path('id') String id);
+}
+
 @ShouldGenerate(
   r'''
     final _data = FormData();