Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NpcBots/bot_ai): Fixed gold looted by bots to be correctly modified by scripts and modules #9

Closed
wants to merge 1 commit into from

Conversation

atrapalis
Copy link

@atrapalis atrapalis commented Jul 27, 2024

Changes Proposed:

The gold amount looted by bots is not being adjusted for any scripts/modules as it is when a player is looting the gold.
The changes proposed here correct that.

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

@atrapalis atrapalis changed the title fix(NpcBots/bot_ai): Fixed gold looted by NpcBots to be correctly modified by scripts and modules fix(NpcBots/bot_ai): Fixed gold looted by bots to be correctly modified by scripts and modules Jul 27, 2024
@trickerer
Copy link
Owner

Ok I'm not going to explain why it isn't entirely correct but here is what I did instead: fddf3cb

@trickerer trickerer closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants