Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 7.2 & main (8.0.0.alpha) #617

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Support Rails 7.2 & main (8.0.0.alpha) #617

merged 4 commits into from
Aug 20, 2024

Conversation

tricknotes
Copy link
Owner

  • Added Rails 7.2 to test matrix
  • Fix for Rails 8.0.0.alpha

@tricknotes
Test on Rails 7.2
f528d80
@tricknotes
Use keyword args to define routes due to Rails 8.0's changes
b95c9b7
@tricknotes
Rewrite mount engine syntax
3fb5343 
To disable deprecation warning since Rails 8.0.

```
DEPRECATION WARNING: Mounting an engine with a hash key name is deprecated and will be removed in Rails 8.1. Please use the at: option instead. Instead of: mount(SomeRackApp => "some_route") Please use: mount SomeRackApp, at: "some_route" (called from mount_ember_assets at /Users/ryunosuke.sato/src/github.com/thoughtbot/ember-cli-rails/lib/ember_cli/route_helpers.rb:40)
```
@tricknotes
Set timezone config explicitly
5c77708 
To disable the following warning:
```
DEPRECATION WARNING: `to_time` will always preserve the receiver timezone rather than system local time in Rails 8.0. To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`. (called from <top (required)> at /Users/ryunosuke.sato/src/github.com/thoughtbot/ember-cli-rails/spec/spec_helper.rb:9)
```
@tricknotes
Copy link
Owner Author

@seanpdoyle
Could you review this PR?

@seanpdoyle seanpdoyle merged commit 2af2b14 into tricknotes:main Aug 20, 2024
14 checks passed
@seanpdoyle
Copy link
Contributor

Thank you!

@tricknotes tricknotes deleted the support-rails-7.2 branch August 21, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tricknotes @seanpdoyle