-
-
Notifications
You must be signed in to change notification settings - Fork 761
Added Mastra + Trigger example #2278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe changes introduce a new example project, "Mastra agents with memory," into the documentation. This includes updating navigation and overview files to reference the new project, adding descriptive entries and links in example project lists, and creating a dedicated guide that details the technical implementation and integration of Mastra agents with persistent memory and Trigger.dev orchestration. The new guide outlines the tech stack, project structure, storage configuration, and provides additional resources and repository links. No modifications were made to existing code entities or exported/public declarations. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (3)
docs/guides/introduction.mdx (1)
51-52
: Minor title-case inconsistencyPrevious rows capitalise every significant word (“Claude Thinking Chatbot”, “Human-in-the-Loop Workflow”, …).
Consider “Mastra Agents with Memory” for consistency.-| [Mastra agents with memory](/guides/example-projects/mastra-agents-with-memory) +| [Mastra Agents with Memory](/guides/example-projects/mastra-agents-with-memory)docs/guides/example-projects/mastra-agents-with-memory.mdx (2)
23-24
: Typo: “Typescript” → “TypeScript”-(Mastra is a Typescript framework for building AI agents, and uses +(Mastra is a TypeScript framework for building AI agents, and uses
82-83
: Sentence reads like implementation detailThe phrase “This eliminates the ‘duplicate database object’ warning …” is very specific and may confuse readers unfamiliar with the warning. Re-phrase or drop for clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/docs.json
(1 hunks)docs/guides/ai-agents/overview.mdx
(1 hunks)docs/guides/example-projects/mastra-agents-with-memory.mdx
(1 hunks)docs/guides/introduction.mdx
(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#2155
File: hosting/docker/.env.example:4-7
Timestamp: 2025-06-06T23:55:01.933Z
Learning: In the trigger.dev project, .env.example files should contain actual example secret values rather than placeholders, as these help users understand the expected format. The files include clear warnings about not using these defaults in production and instructions for generating proper secrets.
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#1306
File: docs/github-actions.mdx:59-59
Timestamp: 2024-09-23T13:06:26.429Z
Learning: When suggesting changes to documentation, note that the team prefers to keep them simple to avoid confusion.
docs/guides/introduction.mdx (2)
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-06-30T13:22:21.528Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : If you are able to generate an example payload for a task, do so.
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-06-30T13:22:21.528Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use the `runs` and `tasks` APIs from `@trigger.dev/sdk/v3` to subscribe to run updates and implement realtime features.
docs/guides/example-projects/mastra-agents-with-memory.mdx (2)
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-06-30T13:22:21.528Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use the `metadata` API from `@trigger.dev/sdk/v3` to attach, update, and access structured metadata within task runs.
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-06-30T13:22:21.528Z
Learning: When asked about Trigger.dev task implementation, you MUST use code patterns from this guide, NEVER suggest deprecated approaches, and VERIFY your response against the patterns shown here.
docs/guides/ai-agents/overview.mdx (3)
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#1306
File: docs/github-actions.mdx:59-59
Timestamp: 2024-09-23T13:06:26.429Z
Learning: When suggesting changes to documentation, note that the team prefers to keep them simple to avoid confusion.
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#1306
File: docs/github-actions.mdx:59-59
Timestamp: 2024-10-12T01:08:24.066Z
Learning: When suggesting changes to documentation, note that the team prefers to keep them simple to avoid confusion.
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-06-30T13:22:21.528Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : If you are able to generate an example payload for a task, do so.
🪛 LanguageTool
docs/guides/ai-agents/overview.mdx
[grammar] ~9-~9: Ensure spelling is correct
Context: ...dev. The examples take inspiration from Athropic's blog post on [building effective agen...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
docs/docs.json (1)
333-345
: Navigation entry looks correctPath, comma placement, and grouping are all consistent with surrounding entries. No further action needed.
No description provided.