Revert Box Shadows changes - #231
Merged
Merged
Conversation
This was a breaking change, the change was too different.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts box shadow changes from version 2.3.0 that were deemed too breaking for a minor release. The changes bump the version to 2.3.1 and restore the previous simpler box shadow values.
Changes:
- Version bumped from 2.3.0 to 2.3.1 across all files
- Box shadow CSS variables reverted from complex multi-layered shadows to simpler single-shadow definitions
- Changes applied consistently across source files and generated distribution files
Reviewed changes
Copilot reviewed 4 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scss/mixins/_banner.scss | Updated version number in banner comment to 2.3.1 |
| scss/_root-modus.scss | Reverted box shadow variables to simpler single-shadow values |
| package.json | Updated package version to 2.3.1 |
| package-lock.json | Updated lockfile version to 2.3.1 |
| hugo.yml | Updated version references and CDN URL to 2.3.1 |
| dist/css/*.css | Regenerated distribution files with reverted box shadows and new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts change from: #210
This was a 'breaking change' in that it was too different form the previous version. Saving the change for the next major version instead.