Conversation
Adds an unimplemented Format([]byte) ([]byte, error) stub and a 64-subtest suite across 12 groups pinning down the behavior contract: classification, sorting, preamble, line endings, blank lines, comments, whitespace, passthrough, deduplication, errors, edge cases, and a kitchen-sink integration case. Idempotence is checked on every passing case. Tests default to Qt 6 style (no version) with a few cases kept versioned to cover both styles. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
qml.Format now takes Options{LibraryPrefixes, ModulePrefixes};
prefixes let callers promote bare names to library or demote dotted
names to module, with precedence ahead of the default heuristics.
Adds contract tests for the override behavior and for 12 validation
rules (empty, leading dot, Qt/qt start, "pragma", overlaps within
and across lists). Prefixes are trimmed before validation and use.
Stub still returns "not implemented".
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Updates the CLI and internal-API design docs to reflect the Options struct added in the previous commit: new --library-prefix and --module-prefix flags with precedence, trim, and validation rules (empty, leading dot, Qt/qt start, "pragma", within-list and cross- list overlaps). INTERNAL_API.md now threads qml.Options through the fs helper signatures and shows it in the per-mode composition table. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This was
linked to
issues
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.