Remove Lombok usage in gateway-ha #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
delombok3
branch
12 times, most recently
from
e227e62 to
1e6cd23
Compare
mosabua
changed the title
mosabua
force-pushed
the
delombok3
branch
16 times, most recently
from
dba86da to
080fca7
Compare
mosabua
force-pushed
the
delombok3
branch
20 times, most recently
from
a8479c6 to
d3b2054
Compare
- Refactor done with Delombok in Intellij, manuallly for simple ones, and manual adjustments - Removed unused loggers - Changed Nullable and Nonnull annotations to consistently use jakarta annotations
mosabua
changed the title
mosabua
commented
Dec 20, 2023
ebyhr
reviewed
Dec 21, 2023
gateway-ha/src/main/java/io/trino/gateway/ha/config/AuthenticationConfiguration.java
Show resolved
Hide resolved
|
Please take a look @willmostly @vishalya and @Chaho12 |
ebyhr
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #104 and #105
Part of #102
Note for reviewers:
I kept formatting changes at minimum to allow relatively easy review. We will do a separate code reformmating to Trino/Airlift style in later PR (after existing PRs are hopefully in).