Conditionally skip Oracle tests #609
Conversation
|
Manually verified that the Oracle tests run in CI: but are skipped on my M1 Macbook. |
willmostly
force-pushed
the
will/conditionally-skip-oracle
branch
from
90e1cb1 to
711e223
Compare
| private static OracleContainer getOracleContainer() | ||
| { | ||
| // reference: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables | ||
| assumeTrue("true".equals(System.getenv("GITHUB_ACTIONS")) |
There was a problem hiding this comment.
I think we should extract this into a shared method .. truly ugly otherwise
There was a problem hiding this comment.
Also .. we should add this info to the development docs
Oracle or anyone else at this stage does NOT publish an image that is suitable for ARM. The same problem with the container image exists in Trino itself and we think this is a good approach to allow local testing and development on ARM-based machines .. currently without this approach you have to skip the tests |
|
That's not true https://blogs.oracle.com/database/post/announcing-oracle-database-23ai-free-container-images-for-armbased-apple-macbook-computers. I would recommend looking into this image's license. |
|
That image is only the latest version of Oracle and from the tutorial it requires an account with the Oracle container registry with a whole lot of restrictions. I dont know if we can use it with GitHub actions either... we can look into it but for now I would think we should merge this PR after cleaning it up |
|
There is lots more info at https://container-registry.oracle.com/ .. which we have to look at for more info. At first glance I saw no docs for accessing older versions |
|
Also .. maybe @wendigo or someone else knows why we use the container we use here .. I will ask |
willmostly
force-pushed
the
will/conditionally-skip-oracle
branch
from
711e223 to
3e6edf4
Compare
The Oracle test container runs very slowly on non x86 architectures, which causes tests to fail. These tests will be skipped unless they are running in Github Actions, on an x86_64, or explicitly enabled by setting the env var TG_RUN_ORACLE_TESTS=true
willmostly
force-pushed
the
will/conditionally-skip-oracle
branch
from
3e6edf4 to
ad771bf
Compare
|
@mosabua I was not convinced with this change. I'm not sure why you merged this PR even I did requested changes. |
|
Apologies @ebyhr. We discussed this in the dev sync this morning and agreed to merge it for now. It is currently a pain to build locally and it will also potentially cause an issue for the release build that @martint will want to run as soon as we get things ready. As such we decided to merge this and then potentially follow up with adjustments. I still have to get around to write the meeting notes .. hopefully after I get the 470 release notes completed. |
|
@mosabua I don't think this change is required for "build". Does Martin run all tests during the release process? |
|
They run by default in the normal build so my local build without this currently fails. Not sure about release build .. but typically they do run unless we have that deactivate in airbase / the release profile. See #605 |
The Oracle test container runs very slowly on non x86 architectures, which causes tests to fail. These tests will be skipped unless they are running in Github Actions, on an x86_64, or explicitly enabled by setting the env var TG_RUN_ORACLE_TESTS=true.
Description
Additional context and related issues
#605
Release notes
(x ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: