Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation docs on monitor configuration #626

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ricardocardante
Copy link

Description

The installation docs refers to a monitorConfiguration configuration node that does not exist. Instead, it should be documented as monitor.

Additional context and related issues

Currently if the trino-gateway user tries to use the monitorConfiguration property it will fail on the deploy with an error like the following:
image

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented Feb 19, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ricardocardante ricardocardante changed the title Fix installation docs by replacing monitorConfiguration with monitor Fix installation docs on monitor configuration Feb 19, 2025
@mosabua
Copy link
Member

mosabua commented Feb 19, 2025

Please submit a signed CLA .. code change looks good and we will wait for CLA processing with merge.

Copy link

cla-bot bot commented Feb 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ricardocardante
Copy link
Author

Please submit a signed CLA .. code change looks good and we will wait for CLA processing with merge.

Thanks, @mosabua.
Added a new change - 9cc9141 - discussed in #621.

CLA submitted, waiting for @martint's validation.

Thank you!

@oneonestar
Copy link
Member

Thanks for the fix.
I think L440-L444 should also be moved to the section above(L430).

```yaml
backendState:
username: "user"
password: "password"
```

Copy link

cla-bot bot commented Feb 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ricardocardante
Copy link
Author

Thanks for the fix. I think L440-L444 should also be moved to the section above(L430).

```yaml
backendState:
username: "user"
password: "password"
```

Done ✅ 0210c75

@oneonestar
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Feb 21, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Feb 21, 2025

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants