Make CI green by changing MSRV policy to "last three stable versions" #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has been red for a while now, caused by us not bumping MSRV.
It doesn't make sense for us to have a generous MSRV policy if we don't maintain it. So make our MSRV policy less generous by changing it to "last three stable versions". This is also what
time(which we frequently have MSRV problems with) will start using, see time-rs/time#535. Clap has an even less generous one: https://docs.rs/clap/latest/clap/If someone is interested in reading more about MSRV policies, I recommend to read these discussions:
The reality is that if someone needs a more generous MSRV policy, then that someone needs to help us maintain it. I'm afraid it's not going to be me. If someone insists on using an old version of Rust, I do not think it is unreasonable for us to insist on that someone to also use an old version of syntect.
Also fix a lint.