ThemeDefaults proof of concept
#480
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #478
Just a simple proof of concept for how the ideas in #478 could look. This adds in a
ThemeDefaultsenum and aTheme::load_default()constructor that can handle loading a single default themeRandom thoughts:
bincodedoesn't support easily ignoring values, so all themes leading up to the one you want are still loadedThemeDefaultsshould be#[non_exhaustive]if you want to support adding more default themes without a semver breaking changeThemeDefaultsshould probably derive more traits, but I left it barebones for the proof-of-conceptThemeDefaults::as_theme_name()wasn't exposed publicly because of the potential confusion that the theme name should match thetheme.name.unwrap()which is not the case for some of the defaults (this confused me at least)default.themedumpsincebincodeserializes a struct with a single field mapped to a value as just the single valueOverall this means that you can write code like this to load a single default theme which is nice when you're only dealing with single themes