test(genai_perf/plots): adding tests for plots module for better test coverage #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adding tests for plots module and enhance testability (e.g.,, moved tests/test_plot_config -> tests/test_plot/test_plot_config)
Additionally, adding a plot exception (plots/exceptions.py) that extends global exception class and handles plot-wise errors. For now just added
EmptyDataError
for the sake of shifting left.Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
None
Where should the reviewer start?
See tests/test_plots/ directory
Test plan:
Caveats:
Background
I noticed plots/ module has lower test coverage comparing to other modules
This PR makes:
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)