Update to align with new comp cv rule #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskewParity
requested changes
Oct 15, 2025
| Chris = 2; | ||
| Daniel = 3; | ||
| enum AirdropType { | ||
| Undefined = 0; |
There was a problem hiding this comment.
After some thought, I'd cut this --> I don't want to be checking for undefined everytime I use this type.
| message Airdrop { | ||
| AirdropIndex Index = 1; // Unique ID | ||
| ODLCObjects Object = 2; // Unique Target | ||
| AirdropType Index = 1; // Unique ID |
There was a problem hiding this comment.
This seems redundant with AirdropType, now that they are single, unique objects.
| */ | ||
| message AirdropSwap { | ||
| AirdropIndex index = 1; | ||
| AirdropType index = 1; |
There was a problem hiding this comment.
do we want to break stuff
There was a problem hiding this comment.
this is a mandatory change, or else protos just wont compile because we dont have airdropindex anymore.
There was a problem hiding this comment.
sorry, I mean the entire type looks redundant. My bad, do we want to break stuff refers to deleting this.
There was a problem hiding this comment.
sure, we can nuke this. ill just check the references for this from gcs and obc
kimichenn
force-pushed
the
feat/cv-stuff
branch
from
a16cd9d to
041a4b1
Compare
AskewParity
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Don't merge until we're done with the corresponding obc and gcs changes