-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--other=add unit test for polaris routing module #44
Open
smartboyjia
wants to merge
6
commits into
trpc-group:master
Choose a base branch
from
smartboyjia:feature/trpc-selector-open-polaris-unittest-dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+299
−10
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
df70625
--other=北极星路由模块用例添加
smartboyjia 6d42da3
--other=用例补充
smartboyjia f0ef5e0
--other=codecc
smartboyjia ebfdbcf
--other=add unittest
smartboyjia 4c5e1fc
--other=add unittest
smartboyjia 9fcc6c3
--other=add unittest
smartboyjia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,8 @@ | |
import com.tencent.polaris.client.api.SDKContext; | ||
import com.tencent.polaris.factory.api.APIFactory; | ||
import com.tencent.polaris.factory.config.ConfigurationImpl; | ||
import com.tencent.polaris.plugins.loadbalancer.random.WeightedRandomBalance; | ||
import com.tencent.polaris.plugins.loadbalancer.ringhash.ConsistentHashLoadBalance; | ||
import com.tencent.trpc.core.common.ConfigManager; | ||
import com.tencent.trpc.core.common.config.PluginConfig; | ||
import com.tencent.trpc.core.rpc.Request; | ||
|
@@ -338,9 +340,10 @@ public void testGetConsumerAPI() { | |
} | ||
|
||
@Test | ||
public void testInit() { | ||
public void testExceptionInit() { | ||
PolarisSelector polarisSelector = new PolarisSelector(); | ||
try { | ||
polarisSelector.setPluginConfig(selectorConfig); | ||
polarisSelector.init(); | ||
Assert.assertNull(polarisSelector.getPolarisAPI()); | ||
polarisSelector.destroy(); | ||
|
@@ -350,7 +353,7 @@ public void testInit() { | |
} | ||
|
||
@Test | ||
public void testWarmup() { | ||
public void testExceptionWarmup() { | ||
PolarisSelector clusterNaming = new PolarisSelector(); | ||
clusterNaming.setPluginConfig(selectorConfig); | ||
clusterNaming.init(); | ||
|
@@ -384,15 +387,15 @@ public void testAsyncSelectOne() { | |
} | ||
|
||
@Test | ||
public void testEmptyAsyncSelectOne() { | ||
public void testGetCriteria() { | ||
PolarisSelector clusterNaming = new PolarisSelector(); | ||
clusterNaming.setPluginConfig(selectorConfig); | ||
clusterNaming.init(); | ||
ServiceId serviceId = DataTest.newServiceId(); | ||
serviceId.setServiceName("service-metadata-select-one"); | ||
clusterNaming.warmup(serviceId); | ||
Request request = DataTest.mockServiceMetadataRequest(); | ||
request.getMeta().setHashVal(null); | ||
request.getMeta().setHashVal("123333"); | ||
CompletionStage<ServiceInstance> future = clusterNaming.asyncSelectOne(serviceId, request); | ||
AtomicReference<Throwable> errorRef = new AtomicReference<>(); | ||
CompletionStage<ServiceInstance> stage = future.whenComplete((res, err) -> { | ||
|
@@ -412,7 +415,6 @@ public void testExceptionAsyncSelectOne() { | |
ServiceId serviceId = DataTest.newServiceId(); | ||
serviceId.setServiceName("fallback"); | ||
Request request = DataTest.request; | ||
request.getMeta().setHashVal(null); | ||
try { | ||
CompletionStage<ServiceInstance> future = clusterNaming | ||
.asyncSelectOne(serviceId, request); | ||
|
@@ -432,4 +434,17 @@ public void testExceptionReport() { | |
return; | ||
} | ||
} | ||
|
||
@Test | ||
public void testExceptionAsyncSelectAll() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 异常测试,需要断言一下,其他也是 |
||
PolarisSelector clusterNaming = new PolarisSelector(); | ||
clusterNaming.setPluginConfig(selectorConfig); | ||
clusterNaming.init(); | ||
try { | ||
ServiceId serviceId = Mockito.mock(ServiceId.class); | ||
clusterNaming.asyncSelectAll(serviceId,DataTest.request); | ||
} catch (Exception e) { | ||
return; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能正常获取到实例,就没有异常吧,也可以判断一下ServiceInstance