Add prometheus selector labels to serviceMonitors #2067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DeeAjayi
commented
Nov 5, 2025
DeeAjayi
commented
- Adds an option to specify prometheus selectorLabels on the global, resource and object level
- added serviceMonitor level labels
Signed-off-by: DeeAjayi <[email protected]>
|
This PR will be automatically closed as it has been stale for 4 days. Please comment if you feel this is still relevant. |
dunefro
reviewed
Nov 11, 2025
| Service Monitor Labels | ||
| */}} | ||
| {{- define "serviceMonitors.labels"}} | ||
| {{- $mergedLabels := mergeOverwrite (include "global.labels" . | fromYaml) .Values.serviceMonitors.labels }} |
Collaborator
There was a problem hiding this comment.
We should use a deepCopy function here. Also fromYaml shouldn't be required
dunefro
reviewed
Nov 11, 2025
dunefro
reviewed
Nov 11, 2025
Collaborator
dunefro
left a comment
dunefro
left a comment
There was a problem hiding this comment.
Logic of merge is not very clean. We should use deepCopy and avoid unnecessary conversions to dict and yaml
|
This PR will be automatically closed as it has been stale for 4 days. Please comment if you feel this is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.