[Error handling 1/N] Drop snafu magic and use explicit thiserror
#235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename "Install mods" -> "Apply changes" to be less confusing. - Rename "Uninstall mods" -> "Uninstall hook and mods". - Added hover text for both buttons to help explain what they do.
For now, drop snafu due to proc-macro magic that makes error handling in code non-obvious. This is a first step towards transitioning to anyhow or another application-based error handling strategy.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series of patches intended to simplify and improve our error handling.
Using
thiserrordoes not make error handling simpler, but it allows we to dropsnafubecausesnafuhas a bunch of magic proc macros that makes it non-obvious when reading the code.thiserrorerror types are compatible witheyrein that they can be used as "leaf" error types in an error trace.Rebased on top of #232.