fix: make maven and pnpm tests immutable #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Romero Montes <[email protected]>
Signed-off-by: Ruben Romero Montes <[email protected]>
ruromero
force-pushed
the
fix/mock-mvn-output
branch
from
858b2c0 to
85a2d3a
Compare
Strum355
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The effective-poms were being deleted and not restored. This fix mocks any interaction with files and temp dirs to make unit tests immutable.
The pnpm integration tests couldn't be re-executed because the imported library
@hapi/joiwas causing a problem in the node_modules that required to delete the folder each timeChecklist